Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failure on OpenBSD #25

Closed
ams opened this issue Sep 25, 2020 · 5 comments · Fixed by #36
Closed

Compilation failure on OpenBSD #25

ams opened this issue Sep 25, 2020 · 5 comments · Fixed by #36
Assignees
@ams

Comments

@ams
Copy link
Contributor

ams commented Sep 25, 2020 •
edited
Loading

FWIW, this (#23 and #22) breaks on OpenBSD. Mostly due to the fact that -lresolv doesn't exist there (nor on some other BSDs), normally these days the libresolv stuff is provided directly by libc both on BSDs and GNU systems but OS X seems to not have followed suite? Dynamically adding -lresolv to the linker line is slightly tricky to do in some form of portable Make -- since everyone wants to be special.

Originally posted by @ams in #23 (comment)
@ams ams self-assigned this Sep 25, 2020
@ams
Copy link
Contributor Author

ams commented Sep 25, 2020

(Another option is that I just make packages for OpenBSD then I can stop caring if I need to write make or gmake)

@larsbrinkhoff
Copy link
Member

larsbrinkhoff commented Sep 25, 2020 via email

@larsbrinkhoff
Copy link
Member

@gwright83 has made some changes for FreeSBD which maybe fixes OpenBSD too?

@gwright83
Copy link

The change allows me to build supdup (as part of ITS) on my FreeBSD gitlab-CI runner. It still requires gmake, but that is not uncommon and I'm willing to live with it.

If it works on OpenBSD as well, I can submit a pull request.

@larsbrinkhoff
Copy link
Member

@gwright83, please do!

@johnsonjh johnsonjh mentioned this issue Aug 9, 2024
Merged
johnsonjh added a commit to johnsonjh/supdup that referenced this issue Oct 27, 2024
@johnsonjh
Portability improvements, cleanup, and bug fixes
2020c0c 
* Add or fix support for building on Solaris, illumos, Linux/musl, NetBSD, OpenBSD, IBM AIX, IBM OS/400 (PASE), Cygwin, and Haiku, which weren't previously cleanly building.
* Use `pkg-config` when available to determine CFLAGS and libraries.
* Initialize some variables in `supdupd`.
* Fix off-by-one error in `supdup`.
* Suppress spurious error when Chaosnet bridge socket is missing.
* Create `README.md`.
* Cleanup Makefile.
* Properly detect bad ports (negative or >65535).
* Fix non-ANSI function declarations.
* Add `*.ln` (*Lint*) files, `supdupd`, and `compile_commands.json` to `.gitignore`.
* Create `.gitattributes`.
* Ensure file handle is valid (non-negative) before closing.
* Correct various spelling errors.
* Tested build under Oracle Solaris, OpenIndiana illumos, Linux/musl, Linux/glibc, IBM AIX, IBM OS/400 (PASE), Haiku, FreeBSD, OpenBSD, NetBSD, DragonFly BSD, Cygwin, and Apple macOS.
* Compilation tested and working with PCC, GCC, Clang, Xcode, IBM XL C, IBM Open XL C, Oracle Studio C, NVIDIA HPC SDK C, Portland Group C, and DMD ImportC.
* Passes Cppcheck and Clang Analyzer.
* Closes: PDP-10#25, PDP-10#35, PDP-10#38

Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
larsbrinkhoff pushed a commit that referenced this issue Oct 28, 2024
@johnsonjh @larsbrinkhoff
Portability improvements, cleanup, and bug fixes
9658d1f 
* Add or fix support for building on Solaris, illumos, Linux/musl, NetBSD, OpenBSD, IBM AIX, IBM OS/400 (PASE), Cygwin, and Haiku, which weren't previously cleanly building.
* Use `pkg-config` when available to determine CFLAGS and libraries.
* Initialize some variables in `supdupd`.
* Fix off-by-one error in `supdup`.
* Suppress spurious error when Chaosnet bridge socket is missing.
* Create `README.md`.
* Cleanup Makefile.
* Properly detect bad ports (negative or >65535).
* Fix non-ANSI function declarations.
* Add `*.ln` (*Lint*) files, `supdupd`, and `compile_commands.json` to `.gitignore`.
* Create `.gitattributes`.
* Ensure file handle is valid (non-negative) before closing.
* Correct various spelling errors.
* Tested build under Oracle Solaris, OpenIndiana illumos, Linux/musl, Linux/glibc, IBM AIX, IBM OS/400 (PASE), Haiku, FreeBSD, OpenBSD, NetBSD, DragonFly BSD, Cygwin, and Apple macOS.
* Compilation tested and working with PCC, GCC, Clang, Xcode, IBM XL C, IBM Open XL C, Oracle Studio C, NVIDIA HPC SDK C, Portland Group C, and DMD ImportC.
* Passes Cppcheck and Clang Analyzer.
* Closes: #25, #35, #38

Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ams ams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Portability improvements, cleanup, and bug fixes johnsonjh/supdup
3 participants
@larsbrinkhoff @gwright83 @ams