Portability improvements, cleanup, and bug fixes #36
Conversation
| @@ -4,33 +4,38 @@ | |||
|
|
|||
| #if USE_CHAOS_STREAM_SOCKET | |||
|
|
|||
| #include <stdio.h> | |||
There was a problem hiding this comment.
Seems this is a but superfluous? I have no opinion though ..
There was a problem hiding this comment.
Yeah, that's just GNU style (modifications via GNU Cppi tool). If you hate it, I can revert.
There was a problem hiding this comment.
I don't see that this was resolved in the discussions. I think minor whitespace cleanup is ok, but major reformatting is not.
There was a problem hiding this comment.
That change is from GNU Cppi which normalizes preprocessor indentation to GNU style - it's indenting by one space because those preprocessor directives are inside the conditional #if block.
There was a problem hiding this comment.
Sure, but we haven't adopted GNU style here. At least it hasn't been discussed and agreed on.
There was a problem hiding this comment.
I can revert to the previous flat style with no indentation (all preprocessor directives left justified) if it's preferred. I apologize, it's something that I (and my default editor configuration) do automatically.
There was a problem hiding this comment.
Oh no, need to apologize! We have these reviews and discussions to hash things out.
In my view, reformatting be more nuisance than it's worth. Say, if someone patched a fork and wanted to apply it here later. It's also polite to adopt the existing code style. So that's my preference, but I'm not saying I have the final say.
There was a problem hiding this comment.
OK, I'll still lean to the new formatting due to the (IMO, massive) readability improvements, but let me know either way.
There was a problem hiding this comment.
I'm with @larsbrinkhoff -- one benefit of keeping formatting is that when you compare to old versions of supdup that might surface it is much much easier to find changes.
As for GNU cppi .. I personally find it ugly, and it isn't that commonly adopted in GNU.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
johnsonjh
force-pushed
the
20240807/johnsonjh/portability
branch
from
73bbd67
to
ff2c6ee
Compare
* Add or fix support for building on Solaris, illumos, Linux/musl, NetBSD, OpenBSD, IBM AIX, and Haiku. * Use pkg-config when available to determine CFLAGS and libraries. * Cleanup Makefile. * Cleanup excess trailing whitespace characters. * Indent nested preprocessor directives with GNU Cppi. * Tested build under Oracle Solaris, OpenIndiana illumos, Linux/musl, Linux/glibc, IBM AIX, Haiku, FreeBSD, OpenBSD, NetBSD, and Apple macOS. * Compilation tested and working with PCC, GCC, Clang, IBM XL C, IBM Open XL C, Oracle Studio C, NVIDIA HPC SDK C, Portland Group C, and DMD ImportC. Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
johnsonjh
force-pushed
the
20240807/johnsonjh/portability
branch
from
ff2c6ee
to
5fc3404
Compare
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
supdup.c:1157:6: error: Array 'loc[128]' accessed at index 128, which is out of bounds. [arrayIndexOutOfBounds]
loc[i] = '\0'; /* terminate */
^
supdup.c:1136:3: note: After for loop, i has value 128
for (i = 0; i < sizeof(loc); i++) {
^
supdup.c:1157:6: note: Array index out of bounds
loc[i] = '\0'; /* terminate */
^
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
On every system I've tested, errno is set to ENOENT rather than ECONNREFUSED. This change successfully suppreses the spurious "connect(server): No such file or directory" error message. Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
This comment was marked as outdated.
This comment was marked as outdated.
johnsonjh
changed the title
johnsonjh
changed the title
johnsonjh
force-pushed
the
20240807/johnsonjh/portability
branch
from
d6161f6
to
d884203
Compare
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
supdup.c:191:19: warning: non-ANSI function declaration of function 'put_newline' Found with smatch. Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
johnsonjh
force-pushed
the
20240807/johnsonjh/portability
branch
from
6df18ea
to
f83521c
Compare
Exclude `doc/` from GitHub Linguist; resolves 48.9% of the project being detected (incorrectly) as CartoCSS. Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>
pkg-configwhen available to determine CFLAGS and libraries.supdupd.supdup.README.md.*.ln(Lint) files,supdupd, andcompile_commands.jsonto.gitignore..gitattributes.Tested build under Oracle Solaris, OpenIndiana illumos, Linux/musl, Linux/glibc, IBM AIX, IBM OS/400 (PASE), Haiku, FreeBSD, OpenBSD, NetBSD, Cygwin, and Apple macOS.
Compilation tested and working with PCC, GCC, Clang, Xcode, IBM XL C, IBM Open XL C, Oracle Studio C, NVIDIA HPC SDK C, Portland Group C, and DMD ImportC.
Passes Cppcheck and Clang Analyzer.
Signed-off-by: Jeffrey H. Johnson <trnsz@pobox.com>