Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper object model for petab.v2 #337

Open
dweindl opened this issue Dec 9, 2024 · 1 comment
Open

Use proper object model for petab.v2 #337

dweindl opened this issue Dec 9, 2024 · 1 comment

Comments

@dweindl
Copy link
Member

dweindl commented Dec 9, 2024

For petab version 2, we will have to rewrite a large part of the current functionality, which gives us the opportunity to rethink the API. For v2, @dilpath and I would like to change the DataFrame based API to a proper object model (e.g., instead of observable_df: pd.DataFrame, we'd have observables: list[Observable]).
This will greatly simplify validation and dealing with default values as well setting proper data types.

@fbergmann
Copy link
Collaborator

we could still have an observable_df property that serialises the observables to df's for those that need it, might also be handy for serialisation later

dweindl added a commit that referenced this issue Dec 11, 2024
Update creation of PEtab problems, validation, conversion from v1 to v2,... to the new long condition table.

Many TODOs remain. To be continued after #337.

---------

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants