Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants + I/O + validation for new conditions/experiments tables #334

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 5, 2024

Related to PEtab-dev/PEtab#586

  • constants for new yaml fields / table columns / ...
  • read/write experiment table
  • add experiments table to Problem, and populate from yaml
  • add first validation functions
  • include missing modules in API docs

To be complemented by separate pull requests.

@dweindl dweindl marked this pull request as ready for review December 5, 2024 15:38
@dweindl dweindl requested a review from a team as a code owner December 5, 2024 15:38
@dweindl dweindl self-assigned this Dec 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 78.49462% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (9baf981) to head (f18f1f6).

Files with missing lines Patch % Lines
petab/v2/lint.py 65.30% 15 Missing and 2 partials ⚠️
petab/v2/problem.py 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
+ Coverage    74.26%   74.36%   +0.10%     
===========================================
  Files           52       53       +1     
  Lines         5048     5138      +90     
  Branches       888      903      +15     
===========================================
+ Hits          3749     3821      +72     
- Misses         962      977      +15     
- Partials       337      340       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl force-pushed the experiment_constants_io branch 5 times, most recently from d0443e3 to 7dd3e41 Compare December 5, 2024 22:10
@dweindl dweindl changed the title Add constants + I/O for new conditions/experiments tables Add constants + I/O + validation for new conditions/experiments tables Dec 5, 2024
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

petab/schemas/petab_schema.v2.0.0.yaml Outdated Show resolved Hide resolved
@dweindl dweindl force-pushed the experiment_constants_io branch from 7dd3e41 to f9a285c Compare December 9, 2024 13:37
* constants
* read/write experiment table
* add experiments table to Problem, and populate from yaml
* some first validation tasks

To be complemented by separate pull requests.
@dweindl dweindl force-pushed the experiment_constants_io branch from f9a285c to f18f1f6 Compare December 9, 2024 13:40
@dweindl dweindl merged commit 4be03c8 into PEtab-dev:develop Dec 9, 2024
7 checks passed
@dweindl dweindl deleted the experiment_constants_io branch December 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants