Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cover symbolic_trace by tracing several vision models in tests #22

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jzhang533
Copy link
Contributor

@jzhang533 jzhang533 commented Mar 8, 2023

selected 10 vision models to trace, 8 of them succeed.
2 of them failed because of

  • failed on DenseNet, since it calls into _C_ops.
  • failed on ShuffleNet, since it calls into x.shape[0:4]

@jzhang533 jzhang533 marked this pull request as draft March 8, 2023 06:51
@jzhang533 jzhang533 marked this pull request as ready for review March 8, 2023 06:57
Copy link
Collaborator

@gglin001 gglin001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 另外对于 test 我们需要 “完全“ 保持 pytest 的写法吗? 还是不限制(unitets or pytest)

@jzhang533
Copy link
Contributor Author

LGTM! 另外对于 test 我们需要 “完全“ 保持 pytest 的写法吗? 还是不限制(unitets or pytest)

我对这个没有特别的想法。也许未来需要,我在想,现在的阶段,我们可以不做限制,

@gglin001 gglin001 merged commit 3f57191 into PFCCLab:main Mar 8, 2023
@jzhang533 jzhang533 deleted the trace_vision_models branch March 8, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants