Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactively remove players from location on disconnect #1389

Merged
merged 1 commit into from
Aug 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ public void onPlayerTeleportMonitor(final PlayerTeleportEvent event) {
this.handleMovementMonitor(event);
}

@EventHandler(priority = EventPriority.MONITOR)
public void onPlayerQuit(final PlayerQuitEvent event) {
// Faster & predictable cleanup even if player object fails to GC
this.lastToLocation.remove(event.getPlayer());
}

private void handleMovementMonitor(PlayerMoveEvent event) {
// It's possible for a PlayerMoveEvent to be modified by another
// HIGHEST handler after we handle it, so we also check it at MONITOR
Expand Down