Cleanup more fields on player & world #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
Pablete1234
force-pushed
the
fix-mem-leaks
branch
from
f7cb906
to
ea459fa
Compare
cswhite2000
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player's last killer & last who hit them is cleared on reset, which avoids online players in new matches who may be in obs retaining who hit them in a past match (and maybe went offline) keeping a reference to older worlds
lastCraftView was only being cleared for non-match worlds, made it cleanup on all worlds when we stop using them
Also cleans up spigot-only nms usage replacing it with
setArrowsStuck