Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Error anchors id instead of name #2

Open
klodeckl opened this issue Mar 14, 2017 · 5 comments
Open

Error anchors id instead of name #2

klodeckl opened this issue Mar 14, 2017 · 5 comments
Labels
enhancement

Comments

@klodeckl
Copy link

According to html5 should be . In my case the browser did not jump to the right anchor when using name attribute. I changed it to id, then it worked. Change is in Classes/View/Form.php, line 1046.
SvenJuergens added a commit to SvenJuergens/formhandler that referenced this issue May 18, 2017
@SvenJuergens
[TASK] remove deprecated (in HTML5) attribute 'name' on anchor Tags
4d64fad 
See issue PHORAX#2 and
https://developer.mozilla.org/en/docs/Web/HTML/Element/a#attr-name
@7elix
Copy link
Collaborator

7elix commented Aug 16, 2017

I think this change should be added.

But removing the name property completely might break JavaScript / CSS selectors on this name.

Let us add the id and keep the name.
Would you please adapt the changeset?

@7elix 7elix self-assigned this Aug 16, 2017
@7elix
Copy link
Collaborator

7elix commented Aug 24, 2017

Hi @SvenJuergens ,

did you find the time to adapt the changeset yet?
Would be nice to have the pull-request in.

Thank you

@7elix 7elix assigned klodeckl and unassigned klodeckl and 7elix Aug 24, 2017
SvenJuergens added a commit to SvenJuergens/formhandler that referenced this issue Aug 24, 2017
@SvenJuergens
[TASK] re added deprecated (in HTML5) attribute 'name' on anchor Tags…
43a0238 
… for compatibility reason

See PHORAX#2
@SvenJuergens
Copy link
Contributor

hi @7elix

the name attribute is back again :)
Sorry, didn't see your question before

@klodeckl
Copy link
Author

klodeckl commented Sep 7, 2017

Thanks a lot. Sorry for my late, I’m a little busy atm. So this is resolved then and can be closed.

@klodeckl klodeckl closed this as completed Sep 7, 2017
@klodeckl klodeckl reopened this Feb 23, 2018
@klodeckl
Copy link
Author

Sorry, I have to open this again. The id attribute is still missing. Without it the error anchors don’t work.

luzat pushed a commit to luzat/formhandler that referenced this issue Nov 23, 2022
@tlueder
Revert "Finisher error response and abort current proccess (PHORAX#1)" (
5fd92c3 
PHORAX#2)

This reverts commit c7ad941.
luzat pushed a commit to luzat/formhandler that referenced this issue Nov 23, 2022
@tlueder
Return finisher errors to Ajax FormSubmit request (PHORAX#3)
75d7b8f 
* Revert "Revert "Finisher error response and abort current proccess (PHORAX#1)" (PHORAX#2)"

This reverts commit 5fd92c3.

* Remove ResponseError

* Added error parameter to process to catch errors

* Return finisher error to ajax request

* Fixed array nesting

* Remove dead code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klodeckl @7elix @SvenJuergens