-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing in pull requests #12
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/test.yml
Outdated
- name: Add Intel repository | ||
run: | | ||
wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
sudo apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
rm GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
echo "deb https://apt.repos.intel.com/oneapi all main" | sudo tee /etc/apt/sources.list.d/oneAPI.list | ||
sudo apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the setup-fortran
action instead of all this setup.
https://github.com/fortran-lang/setup-fortran
(I've been meaning to try it out for ABIN but did not get to it yet, would be great if you could test it here!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nothing escapes your attention on GitHub. Thanks for the idea, I will give it a try, but I first need to understand how the whole stuff works. I copied that from ABIN but I need the fftw
library first which I somehow can't figure out now. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FFTW probably needs to be compiled with the same compiler as qdyn, so you need to move the FFTW compilation after you setup the intel compiler.
I'd recommend just copying the fftw_build
job from ABIN, where I install fftw via apt to avoid compilation. In that case, you need to use to default gfortran compiler otherwise the installed fftw apt package will not be compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nothing escapes your attention on GitHub.
Haha, for some reason I am getting emails for each change on the qdyn repo :-D I was getting a lot of them today. :-P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, cool, thanks for the advice, I will try it someday.
Haha, for some reason I am getting emails for each change on the qdyn repo :-D I was getting a lot of them today. :-P
I had no idea you were watching this repo. I was just playing around thinking no one would see it. :D
No description provided.