Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the test not to freeze on HHVM #491

Merged
merged 1 commit into from
Aug 29, 2014
Merged

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Aug 29, 2014

This resolves #475

@stof
Copy link
Contributor

stof commented Aug 29, 2014

So assertCount() freezes on HHVM ? This should be reported to PHPUnit

@stof
Copy link
Contributor

stof commented Aug 29, 2014

@Nyholm if you can debug the failing tests on HHVM, it would be great as well

@fabpot
Copy link
Contributor

fabpot commented Aug 29, 2014

@Nyholm Great! I'm going to merge this one and we can have follow-up to fix the other tests.

@fabpot fabpot merged commit a564c30 into PHP-CS-Fixer:master Aug 29, 2014
fabpot added a commit that referenced this pull request Aug 29, 2014
This PR was merged into the 0.5.x-dev branch.

Discussion
----------

Fixes the test not to freeze on HHVM

This resolves #475

Commits
-------

a564c30 Fixes the test not to freeze on HHVM
@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 29, 2014

So assertCount() freezes on HHVM ? This should be reported to PHPUnit

I'll submit an issue to PHPUnit

@Nyholm if you can debug the failing tests on HHVM, it would be great as well

Sure, I can start to work on them.

@Nyholm Nyholm deleted the patch-2 branch August 29, 2014 08:39
@staabm
Copy link
Contributor

staabm commented Aug 30, 2014

Related phpunit report sebastianbergmann/phpunit#1413

@keradus keradus mentioned this pull request Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants