Universal/DisallowAlternativeSyntax: various tweaks #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While empty "leafs" of control structures is allowed, it is less common, so make the code used for the tests more realistic. Includes improvements to the inline documentation in the test code file to make it clearer what is being tested.
…control structure bodies When a control structure condition is directly followed by a PHP close tag, a semicolon is silently inserted by PHP and the control structure will turn into a control structure without body. This commit adds additional tests to safeguard that the sniff handles this correctly.
* Minor tweak to the metric name. * Also record metric for single line/no body control structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal/DisallowAlternativeSyntax: improve test code
While empty "leafs" of control structures is allowed, it is less common, so make the code used for the tests more realistic.
Includes improvements to the inline documentation in the test code file to make it clearer what is being tested.
Universal/DisallowAlternativeSyntax: add additional tests with empty control structure bodies
When a control structure condition is directly followed by a PHP close tag, a semicolon is silently inserted by PHP and the control structure will turn into a control structure without body.
This commit adds additional tests to safeguard that the sniff handles this correctly.
Universal/DisallowAlternativeSyntax: minor docs improvements
Universal/DisallowAlternativeSyntax: improve metrics