Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal/DisallowAnonClassParentheses: remove redundant condition #162

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 1, 2022

... and annotate why the condition has been removed, as well as annotating a second likely redundant condition.

Includes a minor tweak to improve the descriptiveness of the "with parameter" metric.

@jrfnl jrfnl added this to the 1.0.0-alpha4 milestone Dec 1, 2022
@jrfnl jrfnl changed the title Universal/[Disallow|Require]AnonClassParentheses: minor metrics improvements Universal/DisallowAnonClassParentheses: minor metrics improvements Dec 1, 2022
... and annotate why the condition has been removed, as well as annotating a second likely redundant condition.

Includes a minor tweak to improve the descriptiveness of the "with parameter" metric.
@jrfnl jrfnl force-pushed the universal/disallow-require-anon-class-parentheses-tweaks-metrics branch from 1a2065f to 1dc503b Compare December 1, 2022 18:54
@jrfnl jrfnl changed the title Universal/DisallowAnonClassParentheses: minor metrics improvements Universal/DisallowAnonClassParentheses: remove redundant condition Dec 1, 2022
@jrfnl jrfnl merged commit 65d41e1 into develop Dec 1, 2022
@jrfnl jrfnl deleted the universal/disallow-require-anon-class-parentheses-tweaks-metrics branch December 1, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant