Universal/ForeachUniqueAssignment: improve analysis for foreach list assignments #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests weren't testing the sniff well enough.
…assignments
This commit:
* Prevents "accidentally correct" handling of code like `foreach ($data as [$id => $id])`, where the first `$id` is not the key for the foreach assignment, so is not the concern of this sniff.
* Improves analysis for key vs value when the value is a list assignment.
Previously, the key and the value would just be compared as found. Now, each individual assignment in the list will be compared against the key.
Notes: nested list assignment are not (yet) taken into account.
Includes improved and additional tests.
jrfnl
deleted the
universal/foreachuniqueassignment-improve-list-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal/ForeachUniqueAssignment: fix some tests
These tests weren't testing the sniff well enough.
Universal/ForeachUniqueAssignment: improve analysis for foreach list assignments
This commit:
foreach ($data as [$id => $id]), where the first$idis not the key for the foreach assignment, so is not the concern of this sniff.Previously, the key and the value would just be compared as found. Now, each individual assignment in the list will be compared against the key.
Notes: nested list assignment are not (yet) taken into account.
Includes improved and additional tests.