Universal/ConstructorDestructorReturn: ignore nested functions/closures #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closures and named (global) functions can be declared _within_ a constructor/destructor method and can be declared to `return` a value. As things were, the sniff did not take this into account and would throw false positives for the `ReturnValueFound` error code when this situation was encountered. The fix as now applied, "jumps" over all nested function declarations within constructors/destructors (including arrow functions, even though thoe can't have a `return`). Includes tests safeguarding this fix. Fixes 201
1 task
jrfnl
deleted the
feature/201-constructordestructorreturn-bug-fix-nested-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closures and named (global) functions can be declared within a constructor/destructor method and can be declared to
returna value.As things were, the sniff did not take this into account and would throw false positives for the
ReturnValueFounderror code when this situation was encountered.The fix as now applied, "jumps" over all nested function declarations within constructors/destructors (including arrow functions, even though thoe can't have a
return).Includes tests safeguarding this fix.
Fixes #201