Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeAnalysis/ConstructorDestructorReturn: correctly ignore PHP-4-style constructors in namespaced classes #272

Merged
merged 1 commit into from
Sep 17, 2023
Merged

CodeAnalysis/ConstructorDestructorReturn: correctly ignore PHP-4-style constructors in namespaced classes #272

merged 1 commit into from
Sep 17, 2023

Commits on Sep 17, 2023

  1. CodeAnalysis/ConstructorDestructorReturn: correctly ignore PHP-4-styl… 

    …e constructors in namespaced classes

Methods with the same name as a class are not recognized as PHP4-style constructors in namespaced classes.

This was so far not taken into account in this sniff, leading to false positives.

A better solution, with a lower performance impact is expected at a later point in time (namespace tracker), however, as my time is limited, it may still be a while before that solution is available.

In the mean time, let's just fix it.

Includes test.
    @jrfnl
    jrfnl committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    1f7fb8a View commit details
    Browse the repository at this point in the history