BCFile::isReference(): sync with upstream #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bugfix for closures declared to return by reference as previously already fixed in the `Operators::isReference()` method, has now also been fixed upstream. This synces the repo for the upstream fix: * Apply the fix to the `BCFile::isReference()` method. * Move the unit test from the test `Diff` file to the `BCFile::isReference()` test case file. Includes adding a changelog entry to include this in the 1.0.0-alpha3 release. Refs: * 142 * squizlabs/php_codesniffer 2977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugfix for closures declared to return by reference as previously already fixed in the
Operators::isReference()method, has now also been fixed upstream.This synces the repo for the upstream fix:
BCFile::isReference()method.Difffile to theBCFile::isReference()test case file.Includes adding a changelog entry to include this in the 1.0.0-alpha3 release.
Refs: