Arrays::isShortArray()/Lists::isShortList(): bugfix for tokenizer issue icw short open tag #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue icw short open tag The tokenizer issue as tested for in the BC1 and BC2 test case files and described in squizlabs/php_codesniffer 1971, where a short array bracket is tokenized as a square bracket, also happens when the PHP short open echo tag is used to open PHP. This commit accounts for this tokenizer bug in the `Arrays::isShortArray()` and the `Lists::isShortList()` methods and adds additional tests to safeguard the correct handling of this in the `Arrays::isShortArray()` and the `Lists::isShortList()` methods.
jrfnl
force-pushed
the
arrays-lists/extra-fix-for-tokenizer-bug
branch
from
f22f8e0
to
b15bae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokenizer issue as tested for in the BC1 and BC2 test case files and described in squizlabs/PHP_CodeSniffer#1971, where a short array bracket is tokenized as a square bracket, also happens when the PHP short open echo tag is used to open PHP.
This commit accounts for this tokenizer bug in the
Arrays::isShortArray()and theLists::isShortList()methods and adds additional tests to safeguard the correct handling of this in theArrays::isShortArray()and theLists::isShortList()methods.