Skip to content

Commit

Permalink
RuleInclusionTest: add test with directory include
Browse files Browse the repository at this point in the history
  • Loading branch information
jrfnl committed Nov 15, 2024
1 parent 78d3d3d commit 7e29324
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
10 changes: 9 additions & 1 deletion tests/Core/Ruleset/RuleInclusionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function resetRuleset()
*/
public function testHasSniffCodes()
{
$this->assertCount(48, self::$ruleset->sniffCodes);
$this->assertCount(49, self::$ruleset->sniffCodes);

}//end testHasSniffCodes()

Expand Down Expand Up @@ -320,6 +320,10 @@ public static function dataRegisteredSniffCodes()
'Generic.Metrics.CyclomaticComplexity',
'PHP_CodeSniffer\Standards\Generic\Sniffs\Metrics\CyclomaticComplexitySniff',
],
[
'Squiz.Files.FileExtension',
'PHP_CodeSniffer\Standards\Squiz\Sniffs\Files\FileExtensionSniff',
],
[
'Generic.NamingConventions.CamelCapsFunctionName',
'PHP_CodeSniffer\Standards\Generic\Sniffs\NamingConventions\CamelCapsFunctionNameSniff',
Expand Down Expand Up @@ -470,6 +474,10 @@ public static function dataSettingInvalidPropertiesOnStandardsAndCategoriesSilen
'sniffClass' => 'PHP_CodeSniffer\Standards\PSR12\Sniffs\Operators\OperatorSpacingSniff',
'propertyName' => 'setforallincategory',
],
'Set property for all sniffs in included category directory' => [
'sniffClass' => 'PHP_CodeSniffer\Standards\Squiz\Sniffs\Files\FileExtensionSniff',
'propertyName' => 'setforsquizfilessniffs',
],
];

}//end dataSettingInvalidPropertiesOnStandardsAndCategoriesSilentlyFails()
Expand Down
9 changes: 9 additions & 0 deletions tests/Core/Ruleset/RuleInclusionTest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@
</properties>
</rule>

<!-- Sniff directory include. -->
<rule ref="./src/Standards/Squiz/Sniffs/Files/">
<properties>
<property name="setforsquizfilessniffs" value="true" />
</properties>
</rule>

<!-- Sniff file include. -->
<rule ref="./src/Standards/Generic/Sniffs/Files/LineLengthSniff.php">
<properties>
<property name="lineLimit" value="10" />
Expand All @@ -39,6 +47,7 @@
</properties>
</rule>

<!-- Ruleset file include. -->
<rule ref="./RuleInclusionTest-include.xml">
<!-- Property being set for all sniffs included in this ruleset. -->
<properties>
Expand Down

0 comments on commit 7e29324

Please sign in to comment.