-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] PSR12 - Boolean Operator Placement #181
[Documentation] PSR12 - Boolean Operator Placement #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @dingo-d !
I've left a few suggestions inline which are optional.
However, the remark about the main description and the typo should definitely be addressed.
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/PSR12/Docs/ControlStructures/BooleanOperatorPlacementStandard.xml
Outdated
Show resolved
Hide resolved
P.S.: Would you mind rebasing the PR before you continue work on it ? That should allow to get a passing build. |
@jrfnl Before I rebase can you just check the change I made to the standard definition? |
I'm fine with it as it is now. For readability you could consider restructuring it a little like below, but that's up to you. Either way is fine by me.
Aside from the "Invalid" description for the second code block, this is now good to go as far as I'm concerned. |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
3771116
to
787fb83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @dingo-d ! LGTM!
The PR contains the documentation for the PSR12/ControlStructures/BooleanOperatorPlacement sniff.
Description
This PR will add the documentation for the above-mentioned sniff, according to the official standard definitions.
Suggested changelog entry
Add documentation for the PSR12 BooleanOperatorPlacement sniff
Related issues/external references
Part of #148
Types of changes
PR checklist