-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Squiz.WhiteSpace.FunctionClosingBraceSpace #408
[Documentation] Squiz.WhiteSpace.FunctionClosingBraceSpace #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@przemekhernik Thank you for this PR and my apologies that it took me a while before I got to reviewing it.
Overall, this looks good. All errors accounted for and the code samples demonstrate the issues clearly.
There are just some grammatical nitpicks to fix and then I'm happy to merge this.
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
src/Standards/Squiz/Docs/WhiteSpace/FunctionClosingBraceSpaceStandard.xml
Outdated
Show resolved
Hide resolved
@przemekhernik Just checking in to see when you have time to finish this off ... ? |
Hi @jrfnl ! I'm sorry for the delay too! I completely missed the email with the notification. I've applied your great suggestions and it's ready to review 🤘 |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @przemekhernik for those updates and for contributing.
All good now. I will rebase the PR (without changes) and merge once the build has passed.
c8360ea
to
889dfd4
Compare
* add docs for FunctionClosingBraceSpace sniff
Description
This PR adds documentation for the
Squiz.WhiteSpace.FunctionClosingBraceSpace
sniff.bin/phpcs --standard=Squiz --generator=text --sniffs=Squiz.WhiteSpace.FunctionClosingBraceSpace
bin/phpcs --standard=Squiz --generator=html --sniffs=Squiz.WhiteSpace.FunctionClosingBraceSpace
Suggested changelog entry
Add documentation for the
Squiz.WhiteSpace.FunctionClosingBraceSpace
sniff.Related issues/external references
Part of #148
Types of changes
PR checklist