Util\Timing::getHumanReadableDuration: improve time display #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes some tiny changes to how the run time is displayed: * For "exactly 1 second", display `1 secs` instead of `1000ms`. * For "exactly 1 minute", display `1 mins` instead of `60 secs`. * When minutes are displayed, only display seconds when there are seconds to display (so no `# mins, 0 secs`). Includes updating the tests to match.
Make the code more self-descriptive and use less "magic numbers" by declaring a couple of constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Util\Timing::getHumanReadableDuration: improve time display
This commit makes some tiny changes to how the run time is displayed:
1 secsinstead of1000ms.1 minsinstead of60 secs.# mins, 0 secs).Includes updating the tests to match.
Util\Timing::getHumanReadableDuration: magic numbers to constants
Make the code more self-descriptive and use less "magic numbers" by declaring a couple of constants.
Suggested changelog entry
Minor improvements to the display of runtime information.