Generators: show deprecation notice for deprecated methods #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
approved these changes
Mar 21, 2025
fredden
reviewed
Apr 13, 2025
fredden
approved these changes
Apr 13, 2025
These methods were _soft_ deprecated in PHPCS 3.12.0 via PR 755 and will be removed in PHPCS 4.0.0. This commit hard deprecates these in case extenders missed the changelog entry. Includes perfunctory tests for the principle of the deprecation notices.
jrfnl
force-pushed
the
feature/generators-show-deprecation-for-methods
branch
from
9d4e2b6 to
a72d2b5
Compare
|
Rebased without changes before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These methods were soft deprecated in PHPCS 3.12.0 via PR #755 and will be removed in PHPCS 4.0.0.
This commit hard deprecates these in case extenders missed the changelog entry.
Includes perfunctory tests for the principle of the deprecation notices.
Suggested changelog entry
Added deprecation notices (hard deprecation) for: