Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: run linting against ubuntu-latest #184

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 24, 2022

No description provided.

@Potherca
Copy link
Member

For the sake of future sanity, I'd rather pin this to ubuntu-20.04. Support for ubuntu-22.04 is still in beta but whenever it is moved to latest by GitHub, I'd rahter not see things accidentally break. Or we could move to 22.4 now and not have to worry about updating things for at least another four years 🤷

Either way, I'd rather not use latest

@jrfnl
Copy link
Member Author

jrfnl commented Jun 25, 2022

@Potherca We're using latest for the tests and to be fair, the ubuntu version shouldn't really matter much for the checks being done here. Happy enough to pin it to 20-04 though.

@Potherca
Copy link
Member

No, you are right... latest is fine here. The linter is not run on the host but in a container on the host.

I got my wires crossed somehow... 🤦

@jrfnl jrfnl merged commit 04f4e8f into master Jun 26, 2022
@jrfnl jrfnl deleted the feature/ghactions-use-ubuntu-latest branch June 26, 2022 10:27
@jrfnl jrfnl changed the title GH Actions: run linting against against ubuntu-latest GH Actions: run linting against ubuntu-latest Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants