NewKeywords: fix too aggressive accounting for PHPCS cross-compat #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of tokens are not correctly back-filled across PHP versions by PHPCS. To that end, a _token translation table_ is used to recognize tokens tokenized as `T_STRING` as the keyword anyway. At the same time, PHPCS retokenizes sometimes too agressively. Having said that, most PHP keywords can be safely used as variable (and property) names and as of PHP 7, as the name of class constants. However, these are tokenized as `T_STRING` which leads to false positives from this sniff. At the same time, keywords in PHP are case-insensitive, so the cross-compat layer should allow for mixed case / uppercase use of the (non magic-constant) keywords as well. This commit fixes both. Includes unit tests.
wimg
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tokens are not correctly back-filled across PHP versions by various PHPCS versions.
To that end, a token translation table is used to recognize tokens tokenized as
T_STRINGas the keyword anyway.At the same time, PHPCS sometimes retokenizes too aggressively, changing
T_STRINGtokens to a keyword token when it shouldn't.Most PHP keywords can be safely used as variable (and property) names and as of PHP 7, as the name of class constants.
Ref: http://php.net/manual/en/reserved.keywords.php
As property names when referenced and class constant names, both when referenced as well as when declared, are tokenized as
T_STRING, this leads to false positives from this sniff.At the same time, keywords in PHP are case-insensitive, so the cross-compat layer should allow for mixed case / uppercase use of the (non magic-constant) keywords as well.
This commit fixes both.
Includes unit tests.