Skip to content

Conversation

martin-georgiev
Copy link
Contributor

No description provided.

@martin-georgiev
Copy link
Contributor Author

This PR will ignore PHP 7.2 failures as the project is not yet migrated to be fully compatible with that version. @Miljar I can do the necessary work in a separate PR once current is merged.

@Miljar
Copy link
Collaborator

Miljar commented Mar 27, 2018

@martin-georgiev I have started working on a reworked version some time ago, but haven't been able to complete it. All work for the Exiftool implementation still needs to be ported. I really should dedicate some more time to it to get a 1.0 version out the door :/

@Miljar Miljar merged commit ce410fe into PHPExif:master Mar 27, 2018
@martin-georgiev
Copy link
Contributor Author

@Miljar Thank you for the speedy collaboration.
I will look later this week for some low hanging fruits like making the project compatible with 7.2 and eventually will add more steps to the CI pipeline.

@Miljar
Copy link
Collaborator

Miljar commented Mar 27, 2018

@martin-georgiev Thanks for your PR! Any help is greatly appreciated. Also, you brought this back to my attention, so I'll try to give php-exif some much needed love ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants