-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix. Placeholder Styles and Positioning #361
Conversation
* Create SlideLayout Sample * When write a Placeholder, fetch the first element of the first paragraph to apply style
@qmachard Have you checked the render in PowerPoint ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qmachard Need some answers. Could you add some unit tests for your additions ?
@@ -54,7 +54,7 @@ | |||
->setVertical(Alignment::VERTICAL_BASE); | |||
$shape->setAutoFit(RichText::AUTOFIT_NORMAL); | |||
$textRun = $shape->createTextRun('01-02-2000')->getFont()->setSize(18); | |||
$shape->setPlaceHolder(new Placeholder(Placeholder::PH_TYPE_DATETIME))->getPlaceholder()->setIdx(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qmachard Why do you remove the index ?
If you remove the Idx, why don't you remove the getPlaceholder() ?
// Slidenumber placeholder | ||
$shape = $oMasterSlide->createRichTextShape(); | ||
$shape->setWidthAndHeight(140, 38)->setOffsetX(770)->setOffsetY(680); | ||
$shape->getActiveParagraph()->getAlignment() | ||
->setHorizontal(Alignment::HORIZONTAL_RIGHT) | ||
->setVertical(Alignment::VERTICAL_BASE); | ||
$shape->setAutoFit(RichText::AUTOFIT_NORMAL); | ||
$textRun = $shape->createTextRun('')->getFont()->setSize(18); | ||
$shape->setPlaceHolder(new Placeholder(Placeholder::PH_TYPE_SLIDENUM))->getPlaceholder()->setIdx(12); | ||
$textRun = $shape->createTextRun('')->getFont()->setSize(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qmachard Why changing the size ?
@qmachard Some news ? |
1 similar comment
@qmachard Some news ? |
@qmachard Hi Could you merge develop branch of PhpPresentation in your branch, please ? Thank you |
Superseeded by #787 |
Hi,
I've just fixed an issue to enable styles and positioning of a Placeholder.
Thanks,