Allow a closure to be passed with image replacement tags #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to supply a closure to the
setImageValue
call on theTemplateProcessor
class.Usage case: we generate serveral documents based from templates and supply a set of replacement tags. One of these tags contains a image that's generated on the fly which results in a performance impact. We must generate this image on every document as we aren't sure if the template contains the replacement tag in question.
This ensures the generation only happens when the tag is found and the
TemplateProcesser
want's to inject the image.Fixes # (issue)
Checklist:
composer run-script check --timeout=0
and no errors were reportedRan the test suite but was unable to run the php-cs script due to what i think are filemode issues on Bash on Windows (the CS script wanted to change all files).