Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in RTF writer #1755

Merged
merged 3 commits into from
Dec 8, 2019
Merged

Improvements in RTF writer #1755

merged 3 commits into from
Dec 8, 2019

Commits on Nov 17, 2019

  1. Errors in RTF Escaping 

    1. Codes meant to be in hex are specified in decimal.
   Consequently characters which don't need escaping are escaped.
2. Special handling (prepend backslash) needed for {, }, and \.
   RTF docs generated with those characters cannot be opened in Word.
3. Tab character needs to be escaped as \tab.
   RTF docs drop these characters.
While running test suite, found that Writer/RTF/ElementTest was coded
only for Unix line endings, and fails on Windows. Changed so that it
would work on either.
    Owen Leibman authored and Owen Leibman committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    a10fe82 View commit details
    Browse the repository at this point in the history

  2. Errors in RTF Escaping 

    1. Codes meant to be in hex are specified in decimal.
   Consequently characters which don't need escaping are escaped.
2. Special handling (prepend backslash) needed for {, }, and .
   RTF docs generated with those characters cannot be opened in Word.
3. Tab character needs to be escaped as \tab.
   RTF docs drop these characters.
While running test suite, found that Writer/RTF/ElementTest was coded
only for Unix line endings, and fails on Windows. Changed so that it
    would work on either.
    Owen Leibman authored and Owen Leibman committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    2513e54 View commit details
    Browse the repository at this point in the history

  3. Formatting changes in source code.

    Owen Leibman authored and Owen Leibman committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    00f9bb5 View commit details
    Browse the repository at this point in the history