Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PHPDoc @param and @return types for several Converter methods #1818

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Fixes PHPDoc @param and @return types for several Converter methods #1818

merged 1 commit into from
Aug 30, 2020

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 4, 2020

Description

Fixes PHPDoc @param and @return types for several Converter methods:

  • Some methods supposedly expect an int, even though float values make sense.
  • Some methods supposedly return a float, even though they return an int.

(Psalm noticed these inconsistencies for me.)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@caugner caugner changed the title docs(Converter): fix @param allowing float Fixes PHPDoc @param and @return types for several Converter methods Feb 4, 2020
@caugner caugner requested a review from troosan February 4, 2020 19:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.633% when pulling 1dee5f3 on caugner:patch-1 into 733f845 on PHPOffice:develop.

@troosan troosan added this to the v0.18.0 milestone Aug 30, 2020
@troosan troosan merged commit ec1b3d3 into PHPOffice:develop Aug 30, 2020
@caugner caugner deleted the patch-1 branch August 31, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants