Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables $rows, $cols in sample #1877

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Unused variables $rows, $cols in sample #1877

merged 1 commit into from
Feb 7, 2021

Conversation

ThanasisMpalatsoukas
Copy link
Contributor

Columns are hardcoded in the basic table loop instead of using the predefined $rows and $cols variables

Description

Columns are hardcoded in the basic table loop instead of using the predefined $rows and $cols variables

Fixes # (issue)

Checklist:

  • [ x ] I have run composer run-script check --timeout=0 and no errors were reported
  • [ x ] The new code is covered by unit tests (check build/coverage for coverage report)
  • [ x ] I have updated the documentation to describe the changes

Columns are hardcoded in the basic table loop instead of using the predefined $rows and $cols variables
@troosan troosan merged commit d592b8e into PHPOffice:develop Feb 7, 2021
@troosan troosan changed the title Unused variables $rows, $cols Unused variables $rows, $cols in sample Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants