Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writer Word2007: Support for padding in Table Cell #2697

Merged
merged 17 commits into from
Jan 22, 2025
Merged

Writer Word2007: Support for padding in Table Cell #2697

merged 17 commits into from
Jan 22, 2025

Conversation

Azamat8405
Copy link
Contributor

@Azamat8405 Azamat8405 commented Nov 19, 2024 •
edited
Loading

Description

Support padding css style for table cell.

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Coverage Status

coverage: 96.921% (-0.03%) from 96.947%
when pulling 9f75457 on Azamat8405:azamat8405SupportpaddingCell
into 337dc27 on PHPOffice:master.

Progi1984
Progi1984 reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks :)

@Progi1984 Progi1984 added this to the 1.4.0 milestone Jan 20, 2025
@Progi1984 Progi1984 self-assigned this Jan 20, 2025
@Azamat8405 Azamat8405 requested a review from Progi1984 January 22, 2025 09:10
Progi1984
Progi1984 reviewed Jan 22, 2025
View reviewed changes
Progi1984
Progi1984 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azamat8405 Could you check the CI, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Jan 22, 2025
@Progi1984 Progi1984 changed the title Support for padding in a table cell Reader HTML : Support for padding in a table cell Jan 22, 2025
@Progi1984 Progi1984 changed the title Reader HTML : Support for padding in a table cell Writer Word2007: Support for padding in Table Cell Jan 22, 2025
Progi1984
Progi1984 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check PHPCSFixer ?

@Progi1984 Progi1984 removed the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Jan 22, 2025
@Progi1984 Progi1984 merged commit 10ae499 into PHPOffice:master Jan 22, 2025
30 checks passed
@Progi1984
Copy link
Member

Thanks @Azamat8405 for your contribution.

@Progi1984 Progi1984 mentioned this pull request Jan 22, 2025
Closed
@Azamat8405 Azamat8405 mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Azamat8405 @coveralls @Progi1984