Fix bug in directory whitelist #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduce the error.
|
I just test with the latest version of the code and I have any problem. Which version and which OS do you use ? |
|
Version: 3bc7f98 Here's the screenshot of the console: And here's the screenshot of code coverage (HTML) result: You see that the result shows all my drive! It only shows PHPWord folder if I implement the change that I suggested. It's minor problem, though. Most people won't use Windows, run the unit tests, and even produce the result in code coverage. I can even change the |
|
No, I valid ... because on Linux, that changes nothing ;) |
Progi1984
added a commit
that referenced
this pull request
Mar 8, 2014
Fix bug in directory whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
phpunit --coverage-htmlto reproduce the error.