Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Date Handling Routines to use DateTime internally #7

Closed
MarkBaker opened this issue Jun 23, 2016 · 5 comments
Closed

Switch Date Handling Routines to use DateTime internally #7

MarkBaker opened this issue Jun 23, 2016 · 5 comments
Assignees
@MarkBaker
Milestone
1.0

Comments

@MarkBaker
Copy link
Member

Switch Date Handling Routines to use DateTime internally (to avoid use of unix Timestamp and ensure full range of Excel DateTimes on 32-bit systems), and use DateTimeInterface for typehinting so that DateTime or DateTime immutable can both be used
@PowerKiKi
Copy link
Member

Is anybody working on that ? I would be willing to do it if the work has not already started and also fix date related unit tests at the same time. What do you say ?

@MarkBaker
Copy link
Member Author

I've been working on the DateTime class, switching it to work with DateTime objects rather than unix timestamps, and using DateTimeInterface where appropriate

@PowerKiKi
Copy link
Member

ok, then I won't do anything about that. I'll have a look at fixing other unit tests.

In the meantime could you please enable Travis CI for this repository ? The badges are shown in the README, but Travis has nod builds to show...

@MarkBaker MarkBaker self-assigned this Aug 13, 2016
MarkBaker pushed a commit that referenced this issue Aug 14, 2016
Merge branch 'develop' into feature/gh-7
850594c 
# Conflicts:
#	tests/PhpSpreadsheet/Shared/DateTest.php
#	tests/rawTestData/Shared/DateTimeExcelToPHP1900.data
#	tests/rawTestData/Shared/DateTimeExcelToPHP1900Timezone.data
#	tests/rawTestData/Shared/DateTimeExcelToPHP1904.data
#	unitTests/rawTestData/Shared/DateTimeExcelToPHP1900.data
#	unitTests/rawTestData/Shared/DateTimeExcelToPHP1904.data
#	unitTests/rawTestData/Shared/DateTimeExcelToTimestamp1900.data
#	unitTests/rawTestData/Shared/DateTimeExcelToTimestamp1904.data
MarkBaker pushed a commit that referenced this issue Aug 14, 2016
Merge branch 'develop' into feature/gh-7
aa97bb3 
# Conflicts:
#	tests/PhpSpreadsheet/Shared/DateTest.php
MarkBaker pushed a commit that referenced this issue Aug 14, 2016
Merge branch 'feature/gh-7' into develop
467babc
MarkBaker pushed a commit that referenced this issue Aug 16, 2016
Merge branch 'feature/gh-7' into develop
e0a9f9e 
# Conflicts:
#	src/PhpSpreadsheet/Shared/Date.php
This was referenced Aug 31, 2016
Closed
Closed
@PowerKiKi PowerKiKi modified the milestone: 2.0 Oct 5, 2016
@PowerKiKi
Copy link
Member

Is it correct that this is now finished ?

@PowerKiKi
Copy link
Member

Assuming this done

@fabiomattei fabiomattei mentioned this issue Nov 8, 2023
Closed
@MiddleSiggy MiddleSiggy mentioned this issue Mar 6, 2024
Closed
8 tasks
@konsoft1 konsoft1 mentioned this issue Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkBaker MarkBaker

Labels
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@PowerKiKi @MarkBaker