Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 Support #1672

Closed
wants to merge 4 commits into from
Closed

PHP8 Support #1672

wants to merge 4 commits into from

Conversation

flavioheleno
Copy link

This is:

- [ ] a bugfix
- [x] a new feature

Checklist:

Why this change is needed?

This change is discussed in more details in #1552

@MarkBaker
Copy link
Member

MarkBaker commented Oct 9, 2020

There is actually a separate branch being used for this work at the moment. PHP8-Testing currently includes testing with PHPUnit 9.4 against the PHP8 nightly build. Code is currently has 7 errors, and is failing 1 test. If you do want to work on this, then it might be worthwhile working from that branch rather than against master.

The biggest remaining problem is handling allow_failure for PHP8, because of the way that we're using job stages rather than a simple grid; I've yet to identify how we can implement that to allow failures for testing against PHP8, while still allowing the other stages to run, which is why it's on a separate branch at the moment.

@MarkBaker
Copy link
Member

MarkBaker commented Oct 9, 2020

And once we have all tests passing with PHP8; the next big step is going through all public methods ensuring that argument names are meaningful, in preparation for PHP8's named arguments changes. But I'd certainly welcome all the help I can get with that change; and meaningful argument names can be done in a fork from master

@PowerKiKi
Copy link
Member

Superseded by #1675

@PowerKiKi PowerKiKi closed this Oct 11, 2020
@flavioheleno flavioheleno deleted the improv/php8-support branch October 12, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants