Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write ignoredErrors Tag Before Drawings #4212

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Nov 1, 2024

Fix #4200. Fix #4145. Although the Xml is valid, Excel insists that worksheet.xml specifies ignoredErrors (introduced with 1.29.0) before legacyDrawing or drawing.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#4200. Fix PHPOffice#4145. Although the Xml is valid, Excel insists that worksheet.xml specifies `ignoredErrors` (introduced with 1.29.0) before `legacyDrawing` or `drawing`.
@oleibman oleibman enabled auto-merge November 5, 2024 05:51
@oleibman oleibman added this pull request to the merge queue Nov 5, 2024
Merged via the queue into PHPOffice:master with commit 915bfc5 Nov 5, 2024
12 of 13 checks passed
@oleibman oleibman deleted the issue4200 branch November 5, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Writer\Xlsx() produce broken files Error in MS Excel after filling XLSX form with PhpOffice\PhpSpreadsheet
1 participant