Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for <s> tag when converting HTML to RichText #4224

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Add support for <s> tag when converting HTML to RichText #4224

merged 5 commits into from
Nov 10, 2024

Conversation

m7913d
Copy link
Contributor

@m7913d m7913d commented Nov 9, 2024 •
edited
Loading

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Fixes #4223

@m7913d m7913d force-pushed the fix_s_tag branch 2 times, most recently from 8608c07 to ed9522d Compare November 9, 2024 17:34
oleibman
oleibman requested changes Nov 10, 2024
View reviewed changes
tests/PhpSpreadsheetTests/Helper/HtmlTest.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/PhpSpreadsheetTests/Helper/HtmlTest.php Outdated Show resolved Hide resolved
tests/PhpSpreadsheetTests/Helper/HtmlTest.php Outdated Show resolved Hide resolved
@m7913d m7913d requested a review from oleibman November 10, 2024 12:13
@oleibman oleibman added this pull request to the merge queue Nov 10, 2024
Merged via the queue into PHPOffice:master with commit dbc2e24 Nov 10, 2024
12 of 13 checks passed
@oleibman
Copy link
Collaborator

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleibman oleibman oleibman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for <s> tag when converting HTML to RichText
2 participants
@m7913d @oleibman