support justifyLastLine

[YoheiZuho]

This is:

• a bugfix
• a new feature
• refactoring
• additional unit tests

Checklist:

• Changes are covered by unit tests
  • Changes are covered by existing unit tests
  • New unit tests have been added
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
• Documentation is updated as necessary

Why this change is needed?

justifyLastLine” is a flag used for the ‘Justify Distributed’ option, which is enabled only when the value of ‘Horizontal’ in the EXCEL setting ‘FormatCells’ is ‘Distributed’. When the option is enabled, an indent of a certain width is added before and after the text in the cell.
This option is often used in Japanese-speaking countries.

[oleibman]

You will need to fix the Phpstan problems and the unit tests that broke as a result of your change. Then you need to make sure that the new property in Alignment is used when calculating the alignment hash code. Then you need to add some tests to demonstrate that your change is working - at a minimum, set the new property in some cell on a spreadsheet (and leave it unset in other cells), write out the spreadsheet, read it back in, and confirm that the property is set or not as desired.

[YoheiZuho]

I'd fix the Phpstan problems and the unit tests.

[oleibman]

Good work on correcting the earlier problems. You still need to include the new field when generating the hash code for Alignment, and to add unit test(s).

[YoheiZuho]

You still need to include the new field when generating the hash code for Alignment, and to add unit test(s).

Excuse me, but which file should I add the test to?

[oleibman]

Despite the number of changes I've requested, you're in pretty good shape. I expect this will be ready to go soon.

[oleibman]

Thank you for your contribution.