-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis cache support #75
Conversation
Thanks for the contribution. You can fix the code style via However there are talk to refactor entirely the caching system in #3 (and also a PR for Redis against PHPExcel). Please join in the discussion and make your opinion known whether PSR-16 support would be an interesting feature. I'll wait until we reach a agreement with @MarkBaker on the cache system future to merge or reject this PR... |
Code style fixed. I'll try to join discussion later. |
I would like to see
Now if Edit: I opened an issue for this. |
@Quix0r You want me to fix that in my new file CachedObjectStorage\Redis.php ? |
@titanrat I'm no dev here, maybe @PowerKiKi or @MarkBaker can say something about it? |
@Quix0r fixed. But only in file which i created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine with me.
@titanrat fine with me. :-) And maybe the people here won't like your PR then. |
@Quix0r Let's see what they say. |
@Quix0r like I said earlier, I won't merge this until we get a decision in #3 about moving to PSR-16. There are chances that this PR will become useless. |
# Conflicts: # src/PhpSpreadsheet/Writer/Html.php
This made obsolete by the introduction of PSR-16, thanks for the contribution anyway. |
Add redis cache support using MemCache type as example