Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling j9, so as to test tunneling #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enabling j9, so as to test tunneling #26

wants to merge 1 commit into from

Conversation

jmgihana
Copy link
Contributor

@jmgihana jmgihana commented May 5, 2022

No description provided.

@jmgihana jmgihana requested a review from mogoodrich May 5, 2022 14:37
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmbabazi ! I added comments about not needing to enable j9 based on our discussion at standup.

Also see my comment about potentially not having to duplicate a few of the other fields a well, thanks!

"vitals",
"vitalsHomepageApp"
],
"extraIdentifierTypes": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat tangential to this request, but if the "extraIdentifierTypes" setting and the "findPatientColumnConfig" setting is exactly the same between the Wellbody production server, Gladi, and the new CI server, we should move the configuration of these two parameters into the "pih-config-sierraLeone-wellbody" file

"dataExports",
"dispensing",
"idcardPrinting",
"j9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we actually don't want to disable this per our discussion at standup.

@@ -8,6 +8,7 @@
"dataExports",
"dispensing",
"idcardPrinting",
"j9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we actually don't want to disable this per our discussion at standup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants