Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all linting warnings #495

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix all linting warnings #495

merged 1 commit into from
Dec 11, 2024

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Dec 11, 2024

Abstract

Another tiny PR that simply fixes all 6 linting warnings due to unused global.js variables.


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • No functional testing, just run npm run lint yourself on master and assert that they are all resolved by this PR.

@JSKitty JSKitty added the Cleanup Removal and/or light refactoring of code label Dec 11, 2024
@JSKitty JSKitty self-assigned this Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit e4e31f4
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6759df69b302e80008446c50
😎 Deploy Preview https://deploy-preview-495--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.
Perhaps we could mark all warnings as a CI fail?

@Duddino Duddino merged commit 717d435 into master Dec 11, 2024
6 checks passed
@JSKitty JSKitty deleted the fix-linting-errors branch December 12, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Removal and/or light refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants