Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Feature request] Focus moves back to the wrong box after sending a transaction #2597

Closed
ambassador000 opened this issue Oct 14, 2021 · 0 comments
Closed

[GUI][Feature request] Focus moves back to the wrong box after sending a transaction #2597

ambassador000 opened this issue Oct 14, 2021 · 0 comments

Comments

@ambassador000
Copy link

  1. Copy-paste some address into the Recipient address field.

  2. Enter any amount in the Amount field and click SEND and confirm the transaction. The following popup dialog at the bottom will appear:
    feature1

  3. While the Transaction sent popup dialog is still presented, quickly copy-paste the address into the Recipient address field again, then click in the Amount box and start typing the numbers into it. Issue is that the focus automatically moves back from the Amount box to the Recipient address field without user's intention, making the user type the numbers into the wrong (Recipient address) field.

Thought: While the user opens the SEND tab, it perfectly makes sense that the Recipient address field comes in focus every time, but while the user is already in SEND tab and after sending the transaction, it doesn't make sense that the focus automatically moves back to the Recipient address field if the user intentionally selected/mouse-clicked the Amount field few moments earlier.

OS: Ubuntu Linux 20.04
@ambassador000 ambassador000 changed the title [GUI][Feature request] [GUI][Feature request] Focus moves back to the wrong box after sending a transaction Oct 14, 2021
@panleone panleone mentioned this issue May 14, 2023
Merged
Fuzzbawls added a commit that referenced this issue Aug 10, 2023
@Fuzzbawls
Merge #2863: [Bug] [GUI] Fix focus on send transaction
6c26a0e 
f7ed184 Fix focus on send (Alessandro Rezzi)

Pull request description:

  This is a trivial but quite annoying bug fix. Basically once a transaction is actually sent from the GUI (so a few seconds after the user presses on "SEND" in the confirmation screen) the focus goes back to the "Recipient address" field regardless the screen the user is currently on.

  Now once the "SEND" button is pressed the focus on "Recipient address" is already (and istantly) gained by the function `showEvent` in send.cpp, so to fix this issue I simply removed the call to `setFocusOnLastEntry` that happens when the transaction is actually sent (which is therefore completely useless).

  This PR also solves #2597 and #1566

ACKs for top commit:
  Liquid369:
    tACK f7ed184
  Fuzzbawls:
    ACK f7ed184

Tree-SHA512: d6c98c3d8af6196b5f63ef0274043e9a3d064f9cba6bc057f2e8188b3c2edbf8c85455eb9767728d7281b60b835748ee0ed48cf2eaf4a973d15ebb557486fb81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panleone @ambassador000