Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored. #1029

Merged

Conversation

furszy
Copy link

@furszy furszy commented Sep 29, 2019

  • OS memory allocation fail handler.
  • OS signal handler registration method created to remove code duplication.
  • AppInitBasicSetup() method created, better code organization of the wallet initialization setup step (step 1).
  • Stop loading block indexes if wallet shutdown was requested.

* OS memory allocation fail handler.
* OS signal handler registration method created to remove code duplication.
* AppInitBasicSetup() method created, organizing better the setup step of the wallet initialization.
@furszy furszy added Backport Startup Wallet startup changes and/or improvements labels Sep 29, 2019
@furszy furszy self-assigned this Sep 29, 2019
 * Stop loading block indexes on wallet startup if shutdown was requested.
 * Wallet loading, wallet rescan and block index load time logged in a more understandable way.
random-zebra
random-zebra previously approved these changes Sep 30, 2019
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e0e9498

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.
Couple minor non-blocking styling nits.

src/wallet/wallet.cpp Outdated Show resolved Hide resolved
src/init.cpp Outdated Show resolved Hide resolved
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eafe9cd

Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eafe9cd

random-zebra added a commit that referenced this pull request Oct 6, 2019
…dler + init step 1 refactored.

eafe9cd [Trivial] Use error() instead of LogPrintf + return false. (furszy)
669794a [Startup][Wallet] Don't continue rescanning the wallet if shutdown was requested. (furszy)
e0e9498 [Logging][Startup]  * Stop loading block indexes on wallet startup if shutdown was requested.  * Wallet loading, wallet rescan and block index load time logged in a more understandable way. (furszy)
ad87023 [Startup][Refactor][Backport] (furszy)

Pull request description:

  * OS memory allocation fail handler.
  * OS signal handler registration method created to remove code duplication.
  * AppInitBasicSetup() method created, better code organization of the wallet initialization setup step (step 1).
  * Stop loading block indexes if wallet shutdown was requested.

ACKs for top commit:
  random-zebra:
    ACK eafe9cd
  Warrows:
    ACK eafe9cd

Tree-SHA512: 65934b760e1b2a0f73ff3aeefefae9fe34b9569d4472dc3d9dd135e11679d1eef8fe0b93b846db844233c28aa23b3e96e36114b7755af3a6237757ddff477fa3
@random-zebra random-zebra merged commit eafe9cd into PIVX-Project:master Oct 6, 2019
random-zebra added a commit that referenced this pull request Oct 11, 2019
…m wallet.h

83d8d00 [Trivial] Init.cpp, instead of use LogPrint, use error. (furszy)
6637fd1 [Wallet][Startup][DB][Backport] bitcoin#10952 BTC back port. Named "Remove vchDefaultKey and have better first run detection". (furszy)

Pull request description:

  Back port from bitcoin#10952.

  This PR is on top of #1029 because of both PRs modifying `init.cpp`.
  Check only the last commit.

ACKs for top commit:
  random-zebra:
    ACK 83d8d00
  Warrows:
    ACK 83d8d00
  Fuzzbawls:
    ACK 83d8d00

Tree-SHA512: 0e05f7f80897a421c541580abbd10af37db083a43c6edf49f61e8d1977c58c6e486b1f17e0eac4fb4e8257200eea3e04b5510321cb4484e110f466f5a5132151
2a5A1Ghu1 added a commit to theohmproject/ohmcoin that referenced this pull request Oct 19, 2020
and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769
squidicuzz pushed a commit to theohmproject/ohmcoin that referenced this pull request Oct 28, 2020
and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769
2a5A1Ghu1 added a commit to theohmproject/ohmcoin that referenced this pull request Oct 28, 2020
* Ohmcoin 3.0 (#63)

* Fix croscompile for win32

* Update Segwit and Zerocoin (#47)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Fix Spork Typo

* Develop (#48)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Update README.md

* Fixes issues when building in 10.15

This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies.

* Qt Frontend Performace

Limits amount of txs loaded

* Added Qt Dependencies for Cross Compile

* Update spork.h

* [Qt][Bug] Load the most recent instead of the first transactions

PIVX-Project/PIVX@ec72107

* Fix QT and Boost bugs

phoreproject/Phore#140

* Update Seeders

* Update Budget and Regtest

* More Budget and Regtest

* Too Expressive

removed arrant parenthesis

* Added select coin strategy

phoreproject/Phore@5928d0b

* allow openssl1.0/1.1 to coexist

phoreproject/Phore@d1b6037

* Prevent RPC calls during warmup

* Changed for loop copies to references, and added stake logging

phoreproject/Phore@3e7f6cf

* Fixed masternode edit deleting two masternodes in list

* Fix staking assertion

phoreproject/Phore@0a6a243

* Added Python test for transaction too large issue

phoreproject/Phore@5b08df9

* Added benchmark in mutex lock

phoreproject/Phore@be2f913

* Fix bugs in mnemonic selection and mint maturity

phoreproject/Phore@c118242

* Revert "Fix bugs in mnemonic selection and mint maturity"

This reverts commit 2f242b0.

* Replaced mapNextTx with smaller map to reduce memory usage.

phoreproject/Phore@3a7c813

* Move ThreadStakeMinter out of net.cpp

phoreproject/Phore@5568806

* Revert "Changed for loop copies to references, and added stake logging"

This reverts commit 113aeea.

* Add missing QPainterPath include

PIVX-Project/PIVX@2e226ad

* Lighter Icons

* Update Checkpoints

* Switch Sporks

* Update Placeholder Address

* Ohmify

* Merge Block Changes (#56)

* Version 3.0.0.1 dev (#53)

* Version 3.0.0.1 dev
- Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold
- Change block time to 4 minutes
- Set  block reward to 6 on activation of new time
- Adjust new block enforce policy to 24 hour span

* fix flag check for; add fIgnoreLegacyBlocks

* move variable out of if statement, fix compile.

* Improve2 (#54)

* WIP: upgrade network upgrade features; testnet fixes..

* add this back for now..

* add missed file, optional.h

* more imports

* adjust imports for consensus.h

* correction

* fix moar missing imports

* add missing vars and fixes

* missing header declare

* changes..

* update makefile

* need this here too..

* fixed compile

* further fixed.

* Zerocoin is not active; Actually use new block version parameter..

* Don't do this, zerocoin not active..

* remove or fix zerocoin at some later point.

* zerocoin is off.

* Adjust new block version update to use protocol version
Prepare for removal of zercoin; refactoring..
Implement sporks to enforce new version lock ins.

* fix compile issues

* get height for tip

* get consensus params

* add missing spork info

* Version 3.0.2.0

* Fixes Wallet Lock Issue (#55)

* Fix block height condition

* Combine Spork 24 into 23

Co-authored-by: Ra's Al Ghul <contact@ohmcoin.org>
Co-authored-by: squidicuz <squid@sqdmc.net>

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

Co-authored-by: Crypto Pliskin <13294167+2a5A1Ghu1@users.noreply.github.com>
Co-authored-by: Ra's Al Ghul <contact@ohmcoin.org>
2a5A1Ghu1 added a commit to theohmproject/ohmcoin that referenced this pull request Oct 28, 2020
* Fix croscompile for win32

* Update Segwit and Zerocoin (#47)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Fix Spork Typo

* Develop (#48)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Update README.md

* Fixes issues when building in 10.15

This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies.

* Qt Frontend Performace

Limits amount of txs loaded

* Added Qt Dependencies for Cross Compile

* Update spork.h

* [Qt][Bug] Load the most recent instead of the first transactions

PIVX-Project/PIVX@ec72107

* Fix QT and Boost bugs

phoreproject/Phore#140

* Update Seeders

* Update Budget and Regtest

* More Budget and Regtest

* Too Expressive

removed arrant paranthesis

* Added select coin strategy

phoreproject/Phore@5928d0b

* allow openssl1.0/1.1 to coexist

phoreproject/Phore@d1b6037

* Prevent RPC calls during warmup

* Changed for loop copies to references, and added stake logging

phoreproject/Phore@3e7f6cf

* Fixed masternode edit deleting two masternodes in list

* Fix staking assertion

phoreproject/Phore@0a6a243

* Added Python test for transaction too large issue

phoreproject/Phore@5b08df9

* Added benchmark in mutex lock

phoreproject/Phore@be2f913

* Fix bugs in mnemonic selection and mint maturity

phoreproject/Phore@c118242

* Revert "Fix bugs in mnemonic selection and mint maturity"

This reverts commit 2f242b0.

* Replaced mapNextTx with smaller map to reduce memory usage.

phoreproject/Phore@3a7c813

* Move ThreadStakeMinter out of net.cpp

phoreproject/Phore@5568806

* Revert "Changed for loop copies to references, and added stake logging"

This reverts commit 113aeea.

* Add missing QPainterPath include

PIVX-Project/PIVX@2e226ad

* Lighter Icons

* Update Checkpoints

* Switch Sporks

* Update Placeholder Address

* Ohmify

* Merge Block Changes (#56)

* Version 3.0.0.1 dev (#53)

* Version 3.0.0.1 dev
- Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold
- Change block time to 4 minutes
- Set  block reward to 6 on activation of new time
- Adjust new block enforce policy to 24 hour span

* fix flag check for; add fIgnoreLegacyBlocks

* move variable out of if statement, fix compile.

* Improve2 (#54)

* WIP: upgrade network upgrade features; testnet fixes..

* add this back for now..

* add missed file, optional.h

* more imports

* adjust imports for consensus.h

* correction

* fix moar missing imports

* add missing vars and fixes

* missing header declare

* changes..

* update makefile

* need this here too..

* fixed compile

* further fixed.

Co-authored-by: Jon <squid@sqdmc.net>

* Zerocoin is not active; Actually use new block version parameter..

* Don't do this, zerocoin not active..

* remove or fix zerocoin at some later point.

* zerocoin is off.

* Adjust new block version update to use protocol version
Prepare for removal of zercoin; refactoring..
Implement sporks to enforce new version lock ins.

* fix compile issues

* get height for tip

* get consensus params

* add missing spork info

* Version 3.0.2.0

Co-authored-by: Crypto Pliskin <13294167+2a5A1Ghu1@users.noreply.github.com>

* Fixes Wallet Lock Issue (#55)

* Fix block height condition

* Combine Spork 24 into 23

Co-authored-by: squidicuz <squid@sqdmc.net>

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

Co-authored-by: Ra's Al Ghul <buddilla@users.noreply.github.com>
Co-authored-by: Andrew LaChasse <buddilla@buddillalappy.local>
Co-authored-by: squidicuz <squid@sqdmc.net>
2a5A1Ghu1 added a commit to theohmproject/ohmcoin that referenced this pull request Nov 2, 2020
* Ohmcoin performance Updates (#70)

* Fix croscompile for win32

* Update Segwit and Zerocoin (#47)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Fix Spork Typo

* Develop (#48)

* Added all of the code for the update

* Fix URL Path

* Fixed default directory path

* Change masternode declarations to karmanode

* change to ohmcoin

* Create .gitignore

* Update .gitignore

* Update .gitignore

* karmanodefy

* Update proposallist.cpp

* Missing class

* Docs Masternode to karmanode

* Change mn(masternode) to kn(karmanode)

* Update doc and comment collateral

* More doc updates

* Fixed Karmanode references in proposal related files.

* Ckarmanode -> CKarmanode

* Karmanodefy Budget System

* Porotocol and Version Bump

* Protocol Enforcement

* Fix typo

* Spork fixes

* Update README.md

* Fixes issues when building in 10.15

This will need to be built against different brew formulas that will be provided on release... This is also a temporary solution once fixes are made for building against updated dependencies.

* Qt Frontend Performace

Limits amount of txs loaded

* Added Qt Dependencies for Cross Compile

* Update spork.h

* [Qt][Bug] Load the most recent instead of the first transactions

PIVX-Project/PIVX@ec72107

* Fix QT and Boost bugs

phoreproject/Phore#140

* Update Seeders

* Update Budget and Regtest

* More Budget and Regtest

* Too Expressive

removed arrant paranthesis

* Added select coin strategy

phoreproject/Phore@5928d0b

* allow openssl1.0/1.1 to coexist

phoreproject/Phore@d1b6037

* Prevent RPC calls during warmup

* Changed for loop copies to references, and added stake logging

phoreproject/Phore@3e7f6cf

* Fixed masternode edit deleting two masternodes in list

* Fix staking assertion

phoreproject/Phore@0a6a243

* Added Python test for transaction too large issue

phoreproject/Phore@5b08df9

* Added benchmark in mutex lock

phoreproject/Phore@be2f913

* Fix bugs in mnemonic selection and mint maturity

phoreproject/Phore@c118242

* Revert "Fix bugs in mnemonic selection and mint maturity"

This reverts commit 2f242b0.

* Replaced mapNextTx with smaller map to reduce memory usage.

phoreproject/Phore@3a7c813

* Move ThreadStakeMinter out of net.cpp

phoreproject/Phore@5568806

* Revert "Changed for loop copies to references, and added stake logging"

This reverts commit 113aeea.

* Add missing QPainterPath include

PIVX-Project/PIVX@2e226ad

* Lighter Icons

* Update Checkpoints

* Switch Sporks

* Update Placeholder Address

* Ohmify

* Merge Block Changes (#56)

* Version 3.0.0.1 dev (#53)

* Version 3.0.0.1 dev
- Increase time between blocks at block 2977924 or when network has reached 95% upgrade threshold
- Change block time to 4 minutes
- Set  block reward to 6 on activation of new time
- Adjust new block enforce policy to 24 hour span

* fix flag check for; add fIgnoreLegacyBlocks

* move variable out of if statement, fix compile.

* Improve2 (#54)

* WIP: upgrade network upgrade features; testnet fixes..

* add this back for now..

* add missed file, optional.h

* more imports

* adjust imports for consensus.h

* correction

* fix moar missing imports

* add missing vars and fixes

* missing header declare

* changes..

* update makefile

* need this here too..

* fixed compile

* further fixed.

Co-authored-by: Jon <squid@sqdmc.net>

* Zerocoin is not active; Actually use new block version parameter..

* Don't do this, zerocoin not active..

* remove or fix zerocoin at some later point.

* zerocoin is off.

* Adjust new block version update to use protocol version
Prepare for removal of zercoin; refactoring..
Implement sporks to enforce new version lock ins.

* fix compile issues

* get height for tip

* get consensus params

* add missing spork info

* Version 3.0.2.0

Co-authored-by: Crypto Pliskin <13294167+2a5A1Ghu1@users.noreply.github.com>

* Fixes Wallet Lock Issue (#55)

* Fix block height condition

* Combine Spork 24 into 23

Co-authored-by: squidicuz <squid@sqdmc.net>

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

* [REST] improve performance for JSON calls

bitcoin/bitcoin@30973e9

JSON calls do not use the raw data generated for
the .bin and .hex calls. By moving the raw data
creation into the .bin and .hex switch branches,
JSON calls become faster.

* Bump Version

* [Model][Performance] Unnecessary double cs_wallet and cs_main lock.

PIVX-Project/PIVX@9d94ea6

* Delete pkg.m4

Delete arrant pkg.m4 file never was needed

* Update Mac version

* Drop QT4 Support

* [BUILD][MacOS] Make Clean Images

* [Refactor][Move Only] Nonwallet RPC Move to Sub-Dir

* [Refactor][Move Only] Wallet Move to Sub-Dir

* Add Memusage

* [REFACTOR] Drop BOOST_FOREACH/REVERSE_FOREACH

* [REFACTOR] Move PAIRTYPE to std::pair & Q_FOREACH/foreach to for

* [LEVELDB]Use std::atomic instead of MemoryBarrier

* Update Copyright

* [Tests] Fix chain ordering in budget tests

PIVX-Project/PIVX#595

* [Doc] Change aarch assert sign output folder

PIVX-Project/PIVX#585

* [Wallet] Adjust staking properties to lower orphan rates.

PIVX-Project/PIVX#617

* [Wallet] Write new transactions to wtxOrdered properly

PIVX-Project/PIVX#597

* [Travis] Add separate job to check doc/logprint/subtree

Further getting up to date with pivx PIVX-Project/PIVX#639

* [Build] Make sure Boost headers are included for libzerocoin

PIVX-Project/PIVX#622

* [Build] Remove unnecessary BOOST dependency

PIVX-Project/PIVX#605

* [Bug] Fix CKarmanodeConfig::read

rebase from upstream. Windows doesn't initialize CService properly
during startup before the masternode.conf file is read.

PIVX-Project/PIVX@9837f53

* Add getaccumulatorvalues RPC

Return the accumulator values associated with a particular block height.

PIVX-Project/PIVX@8a6d425

* [GUI] Fix wrongly displayed balance on Overview tab

PIVX-Project/PIVX#598

* [Wallet] Fix double locked coin when wallet and MN are on same machine

PIVX-Project/PIVX#656

* [Qt] Add Tor service icon to status bar

Tor Icon is displayed when the client is initialized with a successful
tor service connection.

Icon is hidden otherwise.

PIVX-Project/PIVX@f9e18aa

* [Staking] Prevent potential negative out values during stake splitting

PIVX-Project/PIVX#952

* [QT] Set AA_EnableHighDpiScaling attribute early

Set AA_EnableHighDpiScaling attribute early

bitcoin/bitcoin@099e4b9

* [BUILD] Update bitcoin_qt.m4

* [QT] clean up initialize/shutdown signals

qt: clean up initialize/shutdown signals

 - Change initializeResult(int) to initializeResult(bool) to avoid
   implicit type conversion.
 - Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
 - Remove the argument from shutdownResult(int); it was called with a
   constant argument.

bitcoin/bitcoin#9834

* [Refactor] Set to nullptr after delete

bitcoin/bitcoin#10027

* [Main] Unify shutdown proceedure in init rather than per-app

and

[Startup][Refactor][Backport] Memory allocation fail handler + init step 1 refactored.

PIVX-Project/PIVX#1029

PIVX-Project/PIVX#769

* [GUI] Make "For anonymization and staking only" checked by default

PIVX-Project/PIVX#521

* [Trivial] Remove CMasternode::SliceHash

PIVX-Project/PIVX#1513

Co-authored-by: Ra's Al Ghul <buddilla@users.noreply.github.com>
Co-authored-by: Andrew LaChasse <buddilla@buddillalappy.local>
Co-authored-by: squidicuz <squid@sqdmc.net>

* Add checkpoints; Add Activation Blockhash for Version 3.0.2

Co-authored-by: Ra's Al Ghul <buddilla@users.noreply.github.com>
Co-authored-by: squidicuz <squid@sqdmc.net>
@furszy furszy deleted the 2019_memory_allocation_fail_handler branch November 29, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Startup Wallet startup changes and/or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants