[Trivial][Cleanup] Add IsRegTestNet() function in chainparams #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
previously approved these changes
Jan 19, 2020
random-zebra
force-pushed
the
2020_IsRegTest
branch
from
d4e6203
to
ed2325f
Compare
|
Rebased on master. |
random-zebra
force-pushed
the
2020_IsRegTest
branch
from
ed2325f
to
c5a8adb
Compare
Fuzzbawls
approved these changes
Jan 22, 2020
random-zebra
added a commit
that referenced
this pull request
Jan 22, 2020
…arams c5a8adb [Core][Cleanup] Add IsRegTestNet() function in chainparams (random-zebra) Pull request description: This removes many explicit checks `Params().NetworkID() != CBaseChainParams::REGTEST` / `Params().NetworkID() == CBaseChainParams::REGTEST` making the code more readable. ACKs for top commit: Fuzzbawls: ACK c5a8adb Tree-SHA512: ce6373be461c1db87cd48e4046c0c7429a57253a9fbd52d649f65e7ddb0385d0cf87b81f0538b97521f663f8ad79fbcc68f5e2bdbd9ca339ae8599d3d1cc38a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes many explicit checks
Params().NetworkID() != CBaseChainParams::REGTEST/Params().NetworkID() == CBaseChainParams::REGTESTmaking the code more readable.