[Init] Do parameter interaction before creating the UI model #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2020
|
Rebase needed. |
Fuzzbawls
force-pushed
the
2020_init-param-interaction
branch
from
ed536a3
to
9182b90
Compare
|
rebased |
furszy
approved these changes
Mar 12, 2020
random-zebra
approved these changes
Mar 12, 2020
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 13, 2020
…ing the UI model 9182b90 Initialize logging before we do parameter interaction (Jonas Schnelli) dec0787 [QT] Call inits parameter interaction before we create the options model (Jonas Schnelli) 18480ce Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli) Pull request description: Backport of bitcoin#6780 Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2(). ACKs for top commit: furszy: ACK 9182b90 random-zebra: ACK rebase 9182b90 and merging... Tree-SHA512: f01c9b6603452d59c3fa7df8b8f85998b9c716fd3209f80fc6d4591035c995ad577b217d1d7ffd7f642d16fe130ee922ba0394870ec391b8e972587022962611
furszy
added a commit
that referenced
this pull request
Mar 13, 2020
…be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of #1375 Conflicts with #1373 (this to be rebased after both #1373 and #1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 13, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…ing the UI model 9182b90 Initialize logging before we do parameter interaction (Jonas Schnelli) dec0787 [QT] Call inits parameter interaction before we create the options model (Jonas Schnelli) 18480ce Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli) Pull request description: Backport of bitcoin#6780 Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2(). ACKs for top commit: furszy: ACK 9182b90 random-zebra: ACK rebase 9182b90 and merging... Tree-SHA512: f01c9b6603452d59c3fa7df8b8f85998b9c716fd3209f80fc6d4591035c995ad577b217d1d7ffd7f642d16fe130ee922ba0394870ec391b8e972587022962611
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…ing the UI model 9182b90 Initialize logging before we do parameter interaction (Jonas Schnelli) dec0787 [QT] Call inits parameter interaction before we create the options model (Jonas Schnelli) 18480ce Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli) Pull request description: Backport of bitcoin#6780 Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2(). ACKs for top commit: furszy: ACK 9182b90 random-zebra: ACK rebase 9182b90 and merging... Tree-SHA512: f01c9b6603452d59c3fa7df8b8f85998b9c716fd3209f80fc6d4591035c995ad577b217d1d7ffd7f642d16fe130ee922ba0394870ec391b8e972587022962611
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…ing the UI model 9182b90 Initialize logging before we do parameter interaction (Jonas Schnelli) dec0787 [QT] Call inits parameter interaction before we create the options model (Jonas Schnelli) 18480ce Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli) Pull request description: Backport of bitcoin#6780 Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2(). ACKs for top commit: furszy: ACK 9182b90 random-zebra: ACK rebase 9182b90 and merging... Tree-SHA512: f01c9b6603452d59c3fa7df8b8f85998b9c716fd3209f80fc6d4591035c995ad577b217d1d7ffd7f642d16fe130ee922ba0394870ec391b8e972587022962611
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…ing the UI model 9182b90 Initialize logging before we do parameter interaction (Jonas Schnelli) dec0787 [QT] Call inits parameter interaction before we create the options model (Jonas Schnelli) 18480ce Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli) Pull request description: Backport of bitcoin#6780 Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2(). ACKs for top commit: furszy: ACK 9182b90 random-zebra: ACK rebase 9182b90 and merging... Tree-SHA512: f01c9b6603452d59c3fa7df8b8f85998b9c716fd3209f80fc6d4591035c995ad577b217d1d7ffd7f642d16fe130ee922ba0394870ec391b8e972587022962611
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
…lations can be shared 77998ed Combine common error strings so translations can be shared and reused (Luke Dashjr) Pull request description: Backport of bitcoin#7257 Adds helper methods for common translatable string outputs during init, end result is that the number of strings sent to Transifex is reduced/standardized. Based on top of PIVX-Project#1375 Conflicts with PIVX-Project#1373 (this to be rebased after both PIVX-Project#1373 and PIVX-Project#1375 are merged) ACKs for top commit: random-zebra: utACK 77998ed furszy: utACK 77998ed and merging.. Tree-SHA512: 9805b931829f76cbc34b43b7e6141b236d162bd0267342714222612b8e51cdc9d8b35e68971775bd7a489e95a3c4f9b533bbf1ecaa0e56b19a443ed308141c87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of bitcoin#6780
Currently optionsModel(QT) parameters interaction overwrites/dominates initial and depending parameter settings. This PR would factor out init's parameter interaction and call it before AppInit2().