[Wallet] AvailableCoins remove duplicated watchonly config argument.#1759
Merged
furszy merged 1 commit intoPIVX-Project:masterfrom Aug 8, 2020
Merged
Conversation
furszy
force-pushed
the
2020_remove_nWatchOnlyConfig
branch
from
9d4429e to
c5a5af4
Compare
Fuzzbawls
changed the title
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Looking good. Thinking that the RPC argument watchonlyconfig might make more sense as a boolean now.
Though this would require a small change in wallet_basic.py too (which, I believe, is the only place testing the fourth argument of listunspent).
Fuzzbawls
approved these changes
Aug 8, 2020
furszy
added a commit
that referenced
this pull request
Aug 18, 2020
a13c245 AvailableCoins: remove unused "includeZeroValue" flag. (furszy) e74dcd8 AvailableCoins: improving core readability. (furszy) Pull request description: Built on top of #1759 . Improved code readability of the `CWallet::AvailableCoins` method decoupling nested statements and adding comments in between the checks. Plus, removed an unused "add zero value utxo" flag. An ugly area of the code could get pretty readable with some love. #1757 is going further on this area with some more improvements. ACKs for top commit: random-zebra: utACK a13c245 Fuzzbawls: utACK a13c245 Tree-SHA512: 1a5cb1eb058505d66b9a18de60ded211b248568150506e3b7ef32a5b3a8a818055ea85d321caa0c709ee7951dab12bf3450f057edadbf530e9514342194e55f8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning a duplicate watch only filtering configuration from
CWallet::AvailableCoins. The same configuration can be found inCCoinControlobject,fAllowWatchOnlymember.It has mostly non-functional changes and only duplicated code cleanup. The only functional change exception is in
listunspentrpc command.listunspentcommand will not be able anymore to retrieve only the watch only utxo. watch only utxo can be added or not to the utxo set with a custom configuration (same as before).