[Wallet][Refactoring] wallet/init refactoring backports #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
previously approved these changes
Aug 18, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
great work zebra <3 , Code review ACK ae0054e.
Have written few comments but aside from the technical, really minor, details. Conceptually, would be better to move the wallet pre/post initialization related methods to a separate file (possible a tool/factory) and not include them inside the wallet class. Those have really nothing to do with the wallet object responsibilities (obviously not here, in a following work. This is perfect as is, it's a great step forward).
random-zebra
force-pushed
the
202008_wallet_refactoring
branch
from
ae0054e to
de79f65
Compare
Author
|
Rebased. |
>> inspired by bitcoin/bitcoin@fc7c60d Include also zwallet initialization (to be removed after v5.0)
>> adapted from bitcoin/bitcoin@25340b7
random-zebra
force-pushed
the
202008_wallet_refactoring
branch
from
de79f65 to
7e71759
Compare
Author
|
Rebased. |
furszy
approved these changes
Aug 24, 2020
Fuzzbawls
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the following refactoring PRs: