[GUI][BugFix] Masternodes screen, fix impossibility to start Masternodes

[furszy]

Fix impossibility to start Masternodes using the GUI.

This was introduced by beb1cf6 (curiously enough, no one noticed it up until now..), the walletModel is provided to the widget in loadWalletModel, so it can't be used in the MasternodesWidget constructor to construct the mnmodel object.

[Fuzzbawls]

ACK 85b926e

[random-zebra]

nice catch. We need to backport this to the 5.3 branch. utACK 85b926e and merging...

[random-zebra]

(curiously enough, no one noticed it up until now..)

I believe that's because masternodes can still be individually started with the GUI.
What is actually broken is the "Start All" functionality.
This is because, if walletModel is null inside MNModel (as it is with this bug), then collateralTxAccepted is not populated during MNModel::updateMNList(), and, therefore, MasterNodesWidget::startAll fails the isMNCollateralMature check.
This check is missing in MasterNodesWidget::startAlias (we should probably add it there too), so this bug has been undetected for so long.

[ambassador000]

I believe that's because masternodes can still be individually started with the GUI.

Correct. Can confirm that I successfully started a masternode through GUI individually using the v5.3.0rc1.

[furszy]

This check is missing in MasterNodesWidget::startAlias (we should probably add it there too), so this bug has been undetected for so long.

Hmm, not really. We are doing the same check there, you actually just found another bug :).

startAlias() is called from onEditMNClicked() which accesses to the MN model row through the usage of the model index, WAS_COLLATERAL_ACCEPTED column, which.. uses the walletModel and the collateral accepted map (same as startAll), but.. this functions returns true if the collateral is not found instead of returning false :).

So.. the single MN start is working because of another bug actually..

[random-zebra]

Yeah...

if (!collateralTxAccepted.value(txHash) && walletModel) {
    return walletModel->getWalletTxDepth(rec->vin.prevout.hash) > 0;
}