Skip to content

[BUG][GUI] Fix random double/triple transaction record issue #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
random-zebra merged 1 commit into from
Sep 20, 2021
Merged

[BUG][GUI] Fix random double/triple transaction record issue #2551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/qt/transactiontablemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ class TransactionTablePriv

// First check if the amount of txs exceeds the UI limit
if (txesSize > MAX_AMOUNT_LOADED_RECORDS) {
// Sort the txs by date just to be really really sure that them are ordered.
// (this extra calculation should be removed in the future if can ensure that
// txs are stored in order in the db, which is what should be happening)
// Sort the txs by date
sort(walletTxes.begin(), walletTxes.end(),
[](const CWalletTx & a, const CWalletTx & b) -> bool {
return a.GetTxTime() > b.GetTxTime();
Expand Down Expand Up @@ -153,6 +151,10 @@ class TransactionTablePriv
nFirstLoadedTxTime = convertRes.nFirstLoadedTxTime;
}
}

// Now that all records have been cached, sort them by tx hash
std::sort(cachedWallet.begin(), cachedWallet.end(), TxLessThan());

} else {
// Single thread flow
ConvertTxToVectorResult convertRes = convertTxToRecords(wallet, walletTxes);
Expand Down