Inform and stop node if tier two initialization failed. #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the node will re-create its state all over.
Liquid369
approved these changes
Feb 10, 2023
panleone
pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 5, 2024
Don't pass CEvoDB to CDKGSessionHandler and CDKGSession Was never used. Introduce global llmq::llmqDb instance of CDBWrapper This DB is for LLMQ related data that is not part of on-chain consensus. This for example included LLMQ secret key shares and recovered signatures. Don't use CEvoDB in CDKGSessionManager and instead use llmqDb Contributions are not part of on-chain consensus and shouldn't be stored in CEvoDB. Use llmqDb for CRecoveredSigsDb Instead of creating its own CDBWrapper internally. Add key prefix to "rs_" for CRecoveredSigsDb keys This avoids future conflicts with other data stored in llmqDb Add HasVotedOnId/GetVoteForId to CSigningManager These just pass through to CRecoveredSigsDb Use unordered_lru_cache in CRecoveredSigsDb
Fuzzbawls
added a commit
that referenced
this pull request
Nov 9, 2024
901976a Stop tracking interested/participating nodes and send/announce to MNAUTH peers (#2798) (Alexander Block) 59dfdc2 update bestChainLockWithKnownBlock in AcceptedBlockHeader (Alessandro Rezzi) bd0a3f8 Introduce "qsendrecsigs" to indicate that plain recovered sigs should be sent (#2783) (Alexander Block) 846fd9a Make LLMQ/InstantSend/ChainLocks code less spammy (#2781) (Alexander Block) 1a52ad0 Fix LogPrintf call in ::DoInvalidateBlock (Alessandro Rezzi) e3c5eef Multiple fixes/refactorings for ChainLocks (#2765) (Alexander Block) 9dda5d2 Implement LLMQ based InstantSend (#2735) (Alexander Block) 149e3e3 Various small cleanups (#2761) (UdjinM6) cc7450d Use ReleaseNodeVector and CopyNodeVector in PIVX specific code (Alessandro Rezzi) ed463a6 Do not hold cs_vNodes in CSigSharesManager::SendMessages() for too long (#2758) (UdjinM6) cd1809f Implement persistence for LLMQ based InstantSend (#2756) (Alexander Block) 924ee8f Don't be too harsh for invalid CLSIGs (#2742) (Alexander Block) f255314 Fix banning when local node doesn't have the vvec (#2739) (Alexander Block) Pull request description: each commit backports a different PR. The PR number is in the commit message. There are also 3 extra (trivial) commits added by me ACKs for top commit: 901976a Duddino: utACK 901976a Liquid369: uTACK 901976a Tree-SHA512: 70b53ae3fc014c23964cae3452f6c8270d96b3b375c0f172e04039ba6f3b537d56c38677e5e4005c8b810a82b447a64fc978c2d63344b9e9736ceff7db162a18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two problems:
If tier two initialization failed, shutdown the node at startup after informing the problem to the user. (right now, it could only fail due an invalid masternode configuration file).
Do not error out at startup if the masternodes metadata manager was not loaded properly. The node will re-create its state all over while it's running.