[Bug] Fix validation interface data race#2924
Merged
Fuzzbawls merged 2 commits intoPIVX-Project:masterfrom Apr 20, 2024
Merged
Conversation
de59666 to
ddbd4b0
Compare
Duddino
reviewed
Apr 9, 2024
Liquid369
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first commit:
Partially backport bitcoin PR bitcoin#18338 which introduce the functions
RegisterSharedValidationInterfaceandUnregisterSharedValidationInterface. See that PR why using normal pointers is problematic, and howshared_ptrsolve the issue(In a few words the problem is that it can happen that the pointed memory is freed before all signals have been processed, while with shared pointer we are sure that memory will be freed after the last signal is handled)
second commit:
Utilize the new functions to the validation interface
BlockStateCatcher. In order to keep everywhere the logic unchanged (Registering on creation and Unregistering when the object goes out of scope) I created the wrapper classBlockStateCatcherWrapperwhich contains ashared_ptrtoBlockStatecatcher.Those two commits solve the following data race where a
BlockStateCatcherpointer is dereferenced after the pointed memory is freed